Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rightmost tab corner #9575

Merged
2 commits merged into from Mar 30, 2021
Merged

Fix rightmost tab corner #9575

2 commits merged into from Mar 30, 2021

Conversation

ghost
Copy link

@ghost ghost commented Mar 22, 2021

Before and after:
image

The bottom right corner appeared without a radius because of the custom padding.

DHowett
DHowett reviewed Mar 22, 2021
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I believe this is better, but I want to make sure we all agree that the gap between the tab bar and button that becomes visible when you hover is acceptable to everyone.

It is considered acceptable to the WinUI team for the default add tab button:
image

zadjii-msft
zadjii-msft approved these changes Mar 22, 2021
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm very cool with this as-is. If people don't like the gap, then maybe we could add a negative left margin on the new tab button to compensate?

@ghost
Copy link
Author

ghost commented Mar 22, 2021

I think it might be better to wait until WinUI finishes the new design, as it seems they're giving up on the bottom tabs corner. They're currently using a 8,8,4,0 padding.

@DHowett
Copy link
Member

DHowett commented Mar 22, 2021

I think it might be better to wait until WinUI finishes the new design

This could take some time. They're working on some new design components for the tab view, but we'll be sticking with the original design until such time as the new one becomes the default. 😄

@DHowett
Copy link
Member

DHowett commented Mar 30, 2021

Thanks again, and sorry for the delay. I'll fix your conflict.

@DHowett
Copy link
Member

DHowett commented Mar 30, 2021

@msftbot merge this in 1 minute

@ghost ghost added the AutoMerge Marked for automatic merge by the bot when requirements are met label Mar 30, 2021
@ghost
Copy link

ghost commented Mar 30, 2021

Hello @DHowett!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Tue, 30 Mar 2021 20:41:45 GMT, which is in 1 minute

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit 8f16fdd into microsoft:main Mar 30, 2021
DHowett pushed a commit that referenced this pull request Apr 13, 2021
@DHowett
Fix rightmost tab corner (#9575)
0284a91 
Before and after:
![image](https://user-images.githubusercontent.com/78622729/111928492-710b9000-8abc-11eb-9760-0ecd3eb038fb.png)

The bottom right corner appeared without a radius because of the custom padding.

(cherry picked from commit 8f16fdd)
@ghost
Copy link

ghost commented Apr 14, 2021

🎉Windows Terminal v1.7.1033.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Apr 14, 2021

🎉Windows Terminal Preview v1.8.1032.0 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
AutoMerge Marked for automatic merge by the bot when requirements are met
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DHowett @zadjii-msft